cleanup: Split class sinsp_with_test_input into hdr + src #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
|
/milestone 0.15.0 |
|
LGTM label has been added. Git tree hash: 6a8e264ee555c1fe2fbba9f05d07a1d09cdc930a
|
LucaGuerra
approved these changes
Feb 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, federico-sysdig, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
The test fixture class
sinsp_test_with_inputis included in many test source files. It is quite large and was all defined in a single header file. Hoping to improve a bit the build time and for better maintainability it has been split into a header/source pair.Some cleanup of the class has also been performed, for instance the two functions
Setup()/TearDown()have been removed in favor of constructor and destructor as GoogleTest's documentation advises.https://github.com/google/googletest/blob/main/docs/faq.md#should-i-use-the-constructordestructor-of-the-test-fixture-or-setupteardown-ctorvssetup
Also, the gcc-specific
__attribute__((unused)has been replaced with the standard C++ attribute[[maybe_unused]]as the project is now at C++17.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: